Add cri-tools to minikube.iso, for crictl #2404

afbjorklund · 2018-01-07T19:55:24Z

Same as kubernetes/kubeadm#613

[WARNING FileExisting-crictl]: crictl not found in system path

Added in kubernetes/kubeadm#508

kubernetes/kubernetes@bb0cd27

minikube-bot · 2018-01-07T19:56:05Z

Can one of the admins verify this patch?

dlorenc · 2018-01-08T02:14:04Z

@minikube-bot ok to test

dlorenc · 2018-01-08T16:36:43Z

Looks like the build failed with:

CGO_ENABLED=1 /usr/bin/make -j9 PATH="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin:/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/sbin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games:/usr/local/go/bin:/usr/local/go/bin:/usr/local/go/bin" AR="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin/x86_64-minikube-linux-gnu-ar" AS="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin/x86_64-minikube-linux-gnu-as" LD="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin/x86_64-minikube-linux-gnu-ld" NM="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin/x86_64-minikube-linux-gnu-nm" CC="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin/x86_64-minikube-linux-gnu-gcc" GCC="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin/x86_64-minikube-linux-gnu-gcc" CPP="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin/x86_64-minikube-linux-gnu-cpp" CXX="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin/x86_64-minikube-linux-gnu-g++" FC="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin/x86_64-minikube-linux-gnu-gfortran" F77="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin/x86_64-minikube-linux-gnu-gfortran" RANLIB="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin/x86_64-minikube-linux-gnu-ranlib" READELF="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin/x86_64-minikube-linux-gnu-readelf" STRIP="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin/x86_64-minikube-linux-gnu-strip" OBJCOPY="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin/x86_64-minikube-linux-gnu-objcopy" OBJDUMP="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin/x86_64-minikube-linux-gnu-objdump" AR_FOR_BUILD="/usr/bin/ar" AS_FOR_BUILD="/usr/bin/as" CC_FOR_BUILD="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin/ccache /usr/bin/gcc" GCC_FOR_BUILD="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin/ccache /usr/bin/gcc" CXX_FOR_BUILD="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin/ccache /usr/bin/g++" LD_FOR_BUILD="/usr/bin/ld" CPPFLAGS_FOR_BUILD="-I/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/include" CFLAGS_FOR_BUILD="-O2 -I/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/include" CXXFLAGS_FOR_BUILD="-O2 -I/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/include" LDFLAGS_FOR_BUILD="-L/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/lib -Wl,-rpath,/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/lib" FCFLAGS_FOR_BUILD="" DEFAULT_ASSEMBLER="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin/x86_64-minikube-linux-gnu-as" DEFAULT_LINKER="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin/x86_64-minikube-linux-gnu-ld" CPPFLAGS="-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64" CFLAGS="-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -O2 " CXXFLAGS="-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -O2 " LDFLAGS="" FCFLAGS=" -O2 " FFLAGS=" -O2 " PKG_CONFIG="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/bin/pkg-config" STAGING_DIR="/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/host/x86_64-minikube-linux-gnu/sysroot" INTLTOOL_PERL=/usr/bin/perl -C /var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/build/cri-tools-v0.2
make[2]: Entering directory '/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/build/cri-tools-v0.2'
go install \
	github.com/kubernetes-incubator/cri-tools/cmd/critest
go install \
	github.com/kubernetes-incubator/cri-tools/cmd/crictl
can't load package: package github.com/kubernetes-incubator/cri-tools/cmd/critest: cannot find package "github.com/kubernetes-incubator/cri-tools/cmd/critest" in any of:
	/usr/local/go/src/github.com/kubernetes-incubator/cri-tools/cmd/critest (from $GOROOT)
	/var/lib/jenkins/go/src/github.com/kubernetes-incubator/cri-tools/cmd/critest (from $GOPATH)
can't load package: package github.com/kubernetes-incubator/cri-tools/cmd/crictl: cannot find package "github.com/kubernetes-incubator/cri-tools/cmd/crictl" in any of:
	/usr/local/go/src/github.com/kubernetes-incubator/cri-tools/cmd/crictl (from $GOROOT)
	/var/lib/jenkins/go/src/github.com/kubernetes-incubator/cri-tools/cmd/crictl (from $GOPATH)

afbjorklund · 2018-01-08T18:11:48Z

ah, Jenkins sets a variable that I didn't have in my environment. Will set GOPATH explicitly...

CRI_TOOLS_GOPATH = $(@D)/_output

I wondered why that line was there, when there already was a default in the Makefile ? Now I know.

Seems like a critest got included as well...

afbjorklund · 2018-01-08T19:59:39Z

Nope, apparently that wasn't (entirely) it.

make[2]: Entering directory '/var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/build/cri-tools-v0.2'
go install \
        github.com/kubernetes-incubator/cri-tools/cmd/critest
go install \
        github.com/kubernetes-incubator/cri-tools/cmd/crictl
can't load package: package github.com/kubernetes-incubator/cri-tools/cmd/critest: cannot find package "github.com/kubernetes-incubator/cri-tools/cmd/critest" in any of:
        /usr/local/go/src/github.com/kubernetes-incubator/cri-tools/cmd/critest (from $GOROOT)
        /var/lib/jenkins/go/src/k8s.io/minikube/out/buildroot/output/build/cri-tools-v0.2/_output/src/github.com/kubernetes-incubator/cri-tools/cmd/critest (from $GOPATH)
Makefile:36: recipe for target 'critest' failed

When I run it locally, it creates a symlink ?

ifeq ("$(wildcard $(GOPKGDIR))","")
        mkdir -p "$(GOPKGBASEDIR)"
        ln -s "$(CURDIR)" "$(GOPKGBASEDIR)/cri-tools"
endif

afbjorklund · 2018-01-16T22:15:25Z

Installing crictl makes yet another preflight fail... (cri)

[ERROR CRI]: unable to check if the container runtime at "/var/run/dockershim.sock" is running: exit status 1

It is trying to run crictl -r /var/run/dockershim.sock info:

grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: dial unix /var/run/dockershim.sock: connect: no such file or directory"; Reconnecting to {/var/run/dockershim.sock <nil>}

afbjorklund · 2018-02-11T13:01:49Z

Upgraded to CRI for Kubernetes 1.9, to match the minikube 0.25.0 default version

k8s-ci-robot · 2018-02-28T16:25:41Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: afbjorklund
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jimmidyson

Assign the PR to them by writing /assign @jimmidyson in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

afbjorklund · 2018-02-28T17:12:55Z

That preflight error will be fixed in Kubernetes 1.10 :
kubernetes/kubernetes#58802

That is probably also when a stable "crictl" will appear...
Current version is a warm and fuzzy v1.0.0-alpha.0

We don't need critest, because it requires go anyway. But kubeadm insists on crictl being available in path.

kubeadm init is running `crictl -r /var/run/dockershim.sock info` before the socket actually exists (kubelet hasn't started up yet)

afbjorklund · 2018-03-30T11:35:27Z

Updated to "beta", which is the recommended version for k8s 1.10:
https://github.com/kubernetes-incubator/cri-tools#current-status

afbjorklund · 2018-03-30T16:05:28Z

Well, at least the warning is gone from kubeadm 1.10, as promised...
But probably also need a newer version of cri-o, if it should work ?

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 7, 2018

afbjorklund mentioned this pull request Jan 7, 2018

Remove --skip-preflight-checks, ignore unwanted checks #2403

Merged

afbjorklund force-pushed the crictl branch from 231fb12 to a6777dc Compare January 7, 2018 21:07

afbjorklund force-pushed the crictl branch from a6777dc to f16006c Compare January 8, 2018 18:17

afbjorklund force-pushed the crictl branch from f16006c to 85db002 Compare January 8, 2018 20:56

afbjorklund force-pushed the crictl branch from 85db002 to 15c9c8d Compare January 16, 2018 19:52

afbjorklund force-pushed the crictl branch from bcf2e46 to d4837c7 Compare February 11, 2018 13:01

afbjorklund force-pushed the crictl branch from d4837c7 to 4b73490 Compare February 28, 2018 16:25

afbjorklund added 2 commits March 30, 2018 13:30

Add crictl from cri-tools, to minikube.iso

6552702

We don't need critest, because it requires go anyway. But kubeadm insists on crictl being available in path.

Ignore preflight errors from CRI (dockershim.sock)

ea4ed7e

kubeadm init is running `crictl -r /var/run/dockershim.sock info` before the socket actually exists (kubelet hasn't started up yet)

afbjorklund force-pushed the crictl branch from 4b73490 to ea4ed7e Compare March 30, 2018 11:31

afbjorklund mentioned this pull request Mar 30, 2018

Release 0.26.0 #2660

Closed

dlorenc approved these changes Mar 30, 2018

View reviewed changes

dlorenc merged commit 5b54dd6 into kubernetes:master Mar 30, 2018

afbjorklund deleted the crictl branch March 30, 2018 15:37

afbjorklund mentioned this pull request Apr 13, 2018

Can't create Kubernetes v1.9.x on minikube 0.26.0 when using kubeadm bootstrapper #2716

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add cri-tools to minikube.iso, for crictl #2404

Add cri-tools to minikube.iso, for crictl #2404

afbjorklund commented Jan 7, 2018 •

edited

Loading

minikube-bot commented Jan 7, 2018

dlorenc commented Jan 8, 2018

dlorenc commented Jan 8, 2018

afbjorklund commented Jan 8, 2018

afbjorklund commented Jan 8, 2018

afbjorklund commented Jan 16, 2018

afbjorklund commented Feb 11, 2018

k8s-ci-robot commented Feb 28, 2018

afbjorklund commented Feb 28, 2018

afbjorklund commented Mar 30, 2018

afbjorklund commented Mar 30, 2018

Add cri-tools to minikube.iso, for crictl #2404

Add cri-tools to minikube.iso, for crictl #2404

Conversation

afbjorklund commented Jan 7, 2018 • edited Loading

minikube-bot commented Jan 7, 2018

dlorenc commented Jan 8, 2018

dlorenc commented Jan 8, 2018

afbjorklund commented Jan 8, 2018

afbjorklund commented Jan 8, 2018

afbjorklund commented Jan 16, 2018

afbjorklund commented Feb 11, 2018

k8s-ci-robot commented Feb 28, 2018

afbjorklund commented Feb 28, 2018

afbjorklund commented Mar 30, 2018

afbjorklund commented Mar 30, 2018

afbjorklund commented Jan 7, 2018 •

edited

Loading